Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .po and strip down untranslated entries. #11507

Closed
wants to merge 3 commits into from
Closed

Update .po and strip down untranslated entries. #11507

wants to merge 3 commits into from

Conversation

omasanori
Copy link
Contributor

This work is done by execute these commands manually:

$ po4a --copyright-holders="The Rust Project Developers" \
    --package-name="Rust" \
    --package-version="0.10-pre" \
    -M UTF-8 -L UTF-8 \
    doc/po4a.conf
$ for f in doc/po/**/*.po; do
>   msgattrib --untranslated $f -o $f.strip
>   if [ -e $f.strip ]; then
>       mv $f.strip $f
>   else
>       rm $f
>   fi
> done

It should be managed by the build system automatically to use in our
translation workflow, but I've not yet done that.

At least one mostly-translated (over 80% translation rate) document is needed to test the translation workflow, so I'll working on Japanese translation.

@alexcrichton
Copy link
Member

This looks nice! Is this procedure documented anywhere in the translation files? I just want to make sure that this isn't the only location that this is written down.

@omasanori
Copy link
Contributor Author

@alexcrichton Not yet.

The instruction is also in the commit log, but certainly it's better to write current hacky way to anywhere until a better way is available. Please wait.

@alexcrichton
Copy link
Member

Do you plan on making a nicer way soon? If so I'll go ahead and r+ this, but if making it work in the near future won't happen then I'm hesitant to merge.

@omasanori
Copy link
Contributor Author

I can't promise because the current Makefile doesn't work well for translation and testing it requires mostly translated documents. The best translation rate is 33.92% (tutorial.md) now. I have to increase this to 80+% first.

I can wrap these long commands in a few of shell scripts to make it easy now. Is it enough for a while?

@alexcrichton
Copy link
Member

Can you add these in a comment to doc/po4a.conf?

@omasanori
Copy link
Contributor Author

Well, what is "these"?

@brson
Copy link
Contributor

brson commented Jan 13, 2014

@omasanori Thank you for continuing to improve our translation, and sorry we're not giving you more help (I still don't know anything about translation). If you think we need changes to the build system to improve our translation workflow that's probably something we can help with pretty easily. Keep filing issues and submitting PRs!

@omasanori
Copy link
Contributor Author

@brson You're welcome.

At least in Japan, there are people that want a translation of official docs. I appreciate all efforts to keep up-to-date and improve the docs.

The problem is, po4a takes multiple file paths via po4a.conf and puts multiple outputs to the paths that are declared in po4a.conf, so it is difficult to track dependencies from make. I think the localization part of mk/docs.mk needs more considerations. For now, make docs-l10n does nothing even if some files related to translation have been updated.

This work is done by execute these commands manually:

$ po4a --copyright-holder="The Rust Project Developers" \
    --package-name="Rust" \
    --package-version="0.10-pre" \
    -M UTF-8 -L UTF-8 \
    doc/po4a.conf
$ for f in doc/po/**/*.po; do
>   msgattrib --translated $f -o $f.strip
>   if [ -e $f.strip ]; then
>       mv $f.strip $f
>   else
>       rm $f
>   fi
> done

It should be managed by the build system automatically to use in our
translation workflow, but I've not yet done that.

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
@omasanori
Copy link
Contributor Author

I've rebased to keep up with latest changes, fixed some critical typos and added more notes. I didn't grasp what @alexcrichton means "these in a comment", so I think it is not ready for merge.

@alexcrichton
Copy link
Member

Sorry for being a little unclear, but I was just referring to the documentation that you added to README.md, that's great, thanks!

bors added a commit that referenced this pull request Jan 14, 2014
This work is done by execute these commands manually:

    $ po4a --copyright-holders="The Rust Project Developers" \
        --package-name="Rust" \
        --package-version="0.10-pre" \
        -M UTF-8 -L UTF-8 \
        doc/po4a.conf
    $ for f in doc/po/**/*.po; do
    >   msgattrib --untranslated $f -o $f.strip
    >   if [ -e $f.strip ]; then
    >       mv $f.strip $f
    >   else
    >       rm $f
    >   fi
    > done

It should be managed by the build system automatically to use in our
translation workflow, but I've not yet done that.

At least one mostly-translated (over 80% translation rate) document is needed to test the translation workflow, so I'll working on Japanese translation.
@bors bors closed this Jan 14, 2014
@omasanori omasanori deleted the reduce-po branch January 14, 2014 21:04
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 25, 2023
trigger [`transmute_null_to_fn`] on chain of casts

fixes: rust-lang#11485

changelog: trigger [`transmute_null_to_fn`] on chain of casts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants